-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#24280 issueFixed: focus is not set on first item #27412
base: master
Are you sure you want to change the base?
Conversation
Fixed the issue. Now focus should be on first item.
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit aacc94e:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 8c1140461454f55359a4d329f376e8f5bc401e02 (build) |
📊 Bundle size report🤖 This report was generated against 8c1140461454f55359a4d329f376e8f5bc401e02 |
🕵 fluentuiv8 No visual regressions between this PR and main |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 929 | 924 | 5000 | |
Breadcrumb | mount | 2150 | 2172 | 1000 | |
Checkbox | mount | 2184 | 2206 | 5000 | |
CheckboxBase | mount | 1937 | 1936 | 5000 | |
ChoiceGroup | mount | 3627 | 3684 | 5000 | |
ComboBox | mount | 939 | 938 | 1000 | |
CommandBar | mount | 7876 | 7881 | 1000 | |
ContextualMenu | mount | 12514 | 12846 | 1000 | |
DefaultButton | mount | 1085 | 1086 | 5000 | |
DetailsRow | mount | 2768 | 2751 | 5000 | |
DetailsRowFast | mount | 2770 | 2776 | 5000 | |
DetailsRowNoStyles | mount | 2594 | 2598 | 5000 | |
Dialog | mount | 3131 | 3090 | 1000 | |
DocumentCardTitle | mount | 430 | 435 | 1000 | |
Dropdown | mount | 2623 | 2608 | 5000 | |
FocusTrapZone | mount | 1542 | 1553 | 5000 | |
FocusZone | mount | 1517 | 1479 | 5000 | |
GroupedList | mount | 45969 | 52720 | 2 | |
GroupedList | virtual-rerender | 22514 | 22343 | 2 | |
GroupedList | virtual-rerender-with-unmount | 62939 | 63329 | 2 | |
GroupedListV2 | mount | 415 | 426 | 2 | |
GroupedListV2 | virtual-rerender | 399 | 399 | 2 | |
GroupedListV2 | virtual-rerender-with-unmount | 420 | 411 | 2 | |
IconButton | mount | 1480 | 1502 | 5000 | |
Label | mount | 569 | 587 | 5000 | |
Layer | mount | 3527 | 3456 | 5000 | |
Link | mount | 663 | 661 | 5000 | |
MenuButton | mount | 1301 | 1318 | 5000 | |
MessageBar | mount | 25876 | 25871 | 5000 | |
Nav | mount | 2494 | 2495 | 1000 | |
OverflowSet | mount | 1145 | 1135 | 5000 | |
Panel | mount | 2052 | 2077 | 1000 | |
Persona | mount | 1042 | 1081 | 1000 | |
Pivot | mount | 1193 | 1215 | 1000 | |
PrimaryButton | mount | 1193 | 1191 | 5000 | |
Rating | mount | 5789 | 5867 | 5000 | |
SearchBox | mount | 1218 | 1237 | 5000 | |
Shimmer | mount | 2399 | 2399 | 5000 | |
Slider | mount | 1755 | 1754 | 5000 | |
SpinButton | mount | 3547 | 3551 | 5000 | |
Spinner | mount | 628 | 634 | 5000 | |
SplitButton | mount | 2368 | 2370 | 5000 | |
Stack | mount | 664 | 661 | 5000 | |
StackWithIntrinsicChildren | mount | 1217 | 1201 | 5000 | |
StackWithTextChildren | mount | 3572 | 3527 | 5000 | |
SwatchColorPicker | mount | 7554 | 7666 | 5000 | |
TagPicker | mount | 1910 | 1854 | 5000 | |
Text | mount | 624 | 629 | 5000 | |
TextField | mount | 1265 | 1250 | 5000 | |
ThemeProvider | mount | 1116 | 1123 | 5000 | |
ThemeProvider | virtual-rerender | 896 | 935 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1638 | 1646 | 5000 | |
Toggle | mount | 911 | 885 | 5000 | |
buttonNative | mount | 376 | 378 | 5000 |
@GAUARVCHIT You need to generate change files for this PR by running |
Fixed the issue. Now focus should be on first item.
…/fluentui into gauravchit/issue24280
@GAUARVCHIT please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
I appreciate your assistance. I have executed the command 'yarn change' and kindly inform me if any outstanding issues persist. |
@microsoft-github-policy-service agree |
Fixed the issue. Now focus should be on first item.
New Behavior
Related Issue(s)